Add docs about default callback implementation #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
the
no-changelog
FelonEkonom
requested changes
Jun 29, 2023
Rados13
force-pushed
the
MSB-63/improve-callback-description
branch
from
ef1dab0
to
6c559a6
Compare
FelonEkonom
approved these changes
Jun 30, 2023
mat-hek
reviewed
Jun 30, 2023
lib/membrane/bin.ex
Outdated
| @@ -42,6 +42,7 @@ defmodule Membrane.Bin do | |||
| For these reasons, it's important to do any long-lasting or complex work in `c:handle_setup/2`, | |||
| while `handle_init` should be used for things like parsing options, initializing state or | |||
| spawning children. | |||
| By default, it creates a map from opts struct. | |||
There was a problem hiding this comment.
By default, it converts the opts struct to a map and sets them as the bin's state.
mat-hek
approved these changes
Jun 30, 2023
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Rados13
force-pushed
the
MSB-63/improve-callback-description
branch
from
273bb1d
to
a967dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: https://membraneframework.atlassian.net/browse/MSB-63?atlOrigin=eyJpIjoiZWUwYzgzNmJhNDI1NDZiYmI0YjNmZTI1ZjYyYzQzYmEiLCJwIjoiaiJ9